Fix MacCatalyst .framework build #84858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
akoeplinger
commented
Apr 14, 2023
eng/native/functions.cmake
Outdated
Member
Author
There was a problem hiding this comment.
I moved this since it was confusing to have the "Stripping" message printed after we're done stripping
steveisok
approved these changes
Apr 14, 2023
This got broken by dotnet#83903 and wasn't noticed on the PR because we don't build .frameworks unless you pass `/p:BuildDarwinFrameworks=true`. For .frameworks we need to use a different install command and we also don't need to codesign them, it actually causes an error trying to do so: > /Users/alexander/dev/runtime/artifacts/obj/mono/maccatalyst.x64.Release/mono/mini/Mono.release.framework/Versions/C/Mono.release: code object is not signed at all > In subcomponent: /Users/alexander/dev/runtime/artifacts/obj/mono/maccatalyst.x64.Release/mono/mini/Mono.release.framework/Versions/C/Mono.release.dwarf
akoeplinger
force-pushed
the
fix-catalyst-build
branch
from
9bb0aa7 to
2722e7a
Compare
am11
reviewed
Apr 14, 2023
| string(TOLOWER "${CMAKE_BUILD_TYPE}" LOWERCASE_CMAKE_BUILD_TYPE) | ||
| if (LOWERCASE_CMAKE_BUILD_TYPE STREQUAL release) | ||
| set(strip_command ${strip_command} && codesign -f -s - ${strip_source_file}) | ||
| if (CLR_CMAKE_TARGET_OSX) |
Member
There was a problem hiding this comment.
Perhaps just:
Suggested change
| if (CLR_CMAKE_TARGET_OSX) | |
| if (NOT CLR_CMAKE_TARGET_MACCATALYST) |
?
Member
Author
There was a problem hiding this comment.
the only other targets are iOS/tvOS and it doesn't make much sense to codesign there either since that will be done during the app build. we've also not done this in the mono.proj version before you change so I think it's fine to limit it to OSX.
This was referenced Apr 14, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got broken by #83903 and wasn't noticed on the PR because we don't build .frameworks unless you pass
/p:BuildDarwinFrameworks=true.For .frameworks we need to use a different install command and we also don't need to codesign them, it actually causes an error trying to do so (only on Catalyst though, not on iOS/tvOS for some reason):
/cc @am11